Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo - AdvancedRemove -> AdvancedRemote #14

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

helloimalemur
Copy link
Contributor

There are a few places where "AdvancedRemote" was misspelled as "AdvancedRemove"

https://refactoring.guru/design-patterns/bridge/rust/example

@fadeevab
Copy link
Owner

@helloimalemur Oh, thanks! Could you please also fix one Clippy error from GitHub Workflows run: https://github.com/fadeevab/design-patterns-rust/actions/runs/6950499122/job/18924253161?pr=14 👆

@helloimalemur
Copy link
Contributor Author

I ran and applied the fix reported by
cargo clippy --fix --bin "command" --allow-dirty
as well as
cargo clippy -- -D clippy::all.
I believe it should pass the workflow checks now.

@fadeevab
Copy link
Owner

fadeevab commented Nov 23, 2023

@helloimalemur Formatting also (rustfmt )... I also fixed permissions, and now GitHub Actions should run automatically.

@helloimalemur
Copy link
Contributor Author

Thanks! I ran cargo fmt. interestingly, it updated a different file than I had touched.

@fadeevab fadeevab merged commit 104ecdb into fadeevab:main Nov 24, 2023
1 check passed
@fadeevab
Copy link
Owner

@helloimalemur Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants